-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds index page #46
Merged
Merged
Adds index page #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified the all-terms page by adding the full definitons on the page so that the user doesn't have to go through an extra click to the search results page - Fixes bug with nav not displaying on the topmost part of the page - Removes the map in favour of an array when obtaining the termItems from the master csv file
- Adds a button that floats on the all-terms page so that anyone scrolling can easily access the nav - Made Nav background color gray
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/glosseta/glosseta/YwKoJiN9Jq2pg9PtGnx6WCr1FxFe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a much needed index page to contain all the terms and definitions on a single place. This PR also introduces a navigation bar so that users can more easily jump between pages. There were also a variety of styling fixes applied throughout the app.
Any helpful background information around the changes?
Many users requested a page so that they can just scroll through and read up on different terms
Any new dependencies? Why were they added?
yes:
Relevant Screenshots/gifs
Will add upon completion
Does is close any issue(s)?
Closes #21