Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds index page #46

Merged
merged 35 commits into from
Nov 29, 2021
Merged

Adds index page #46

merged 35 commits into from
Nov 29, 2021

Conversation

narbs91
Copy link
Member

@narbs91 narbs91 commented Nov 28, 2021

What does this PR do?

This PR adds a much needed index page to contain all the terms and definitions on a single place. This PR also introduces a navigation bar so that users can more easily jump between pages. There were also a variety of styling fixes applied throughout the app.

Any helpful background information around the changes?

Many users requested a page so that they can just scroll through and read up on different terms

Any new dependencies? Why were they added?

yes:

  • fast-csv: Added so that the master csv can be parsed and used to fill the index page

Relevant Screenshots/gifs

Will add upon completion

Does is close any issue(s)?

Closes #21

- Simplified the all-terms page by adding the full definitons on the page so that the user doesn't have to go through an extra click to the search results page
- Fixes bug with nav not displaying on the topmost part of the page
- Removes the map in favour of an array when obtaining the termItems from the master csv file
- Adds a button that floats on the all-terms page so that anyone scrolling can easily access the nav
- Made Nav background color gray
@vercel
Copy link

vercel bot commented Nov 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/glosseta/glosseta/YwKoJiN9Jq2pg9PtGnx6WCr1FxFe
✅ Preview: https://glosseta-git-adds-index-page-glosseta.vercel.app

@narbs91 narbs91 added the enhancement New feature or request label Nov 28, 2021
@narbs91 narbs91 self-assigned this Nov 28, 2021
@narbs91 narbs91 marked this pull request as ready for review November 29, 2021 18:08
@narbs91 narbs91 merged commit 75f9dab into main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Adding an index page
1 participant