Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: Remove default sorting for untranslated view #1106

Merged
merged 1 commit into from
May 1, 2020

Conversation

ocean90
Copy link
Member

@ocean90 ocean90 commented May 1, 2020

The untranslated filter was added in 0eb77ef together with a link to get random untranslated strings. But the random link was removed 77d3ccb.

This removes the hardcoded sorting to ensure the one of the profile setting is used. It also prevents having a "Current Filter" link when clicking on the Untranslated column in the translations table. Instead the default "Untranslated" link should be highlighted.

filter-view

@ocean90 ocean90 added the [Type] Enhancement A suggestion for improvement. label May 1, 2020
@ocean90 ocean90 added this to the 3.0 milestone May 1, 2020
@ocean90 ocean90 self-assigned this May 1, 2020
@ocean90 ocean90 merged commit 3885fe2 into develop May 1, 2020
@ocean90 ocean90 deleted the fix/remove-default-sort-untranslated branch May 1, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant