Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove locales/no-variants/locales.php #1173

Closed
ocean90 opened this issue Jun 3, 2020 · 1 comment · Fixed by #1175
Closed

Remove locales/no-variants/locales.php #1173

ocean90 opened this issue Jun 3, 2020 · 1 comment · Fixed by #1175
Labels
[Type] Locales
Milestone
3.0

Comments

@ocean90
Copy link
Member

ocean90 commented Jun 3, 2020

Since there's no easy way to ensure that both locale files are in sync I'm suggesting to simply remove the no-variants file.

If someone doesn't want the variants feature they can either filter the locales through gp_locale_definitions_arrary or create their own copy.
@ocean90 ocean90 added this to the 3.0 milestone Jun 3, 2020
@pedro-mendonca
Copy link
Member

Is it a typo on gp_locale_definitions_arrary?

..._arrary -> ..._array

@pedro-mendonca pedro-mendonca mentioned this issue Jun 3, 2020
Merged
@ocean90 ocean90 mentioned this issue Jun 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Locales
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Locales: Remove the no-variants version of locales.php GlotPress/GlotPress
2 participants
@ocean90 @pedro-mendonca