Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very long words in strings are breaking UI #875

Closed
audrasjb opened this issue Feb 13, 2018 · 2 comments
Closed

Very long words in strings are breaking UI #875

audrasjb opened this issue Feb 13, 2018 · 2 comments
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Milestone

Comments

@audrasjb
Copy link

Hello,

A french team contributor noticed very long words can break GlotPress UI.

Example: https://translate.wordpress.org/projects/wp-plugins/duplicate-page/stable-readme/fr/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=5633108&filters%5Btranslation_id%5D=53864572

capture d ecran 2018-02-13 a 22 56 18

A small patch will follow this issue.

Cheers,
Jb

@fr-laurentn
Copy link

@audrasjb Thanks for reporting the issue.

Actually, the issue I noticed was when the editor is closed.
So it seems that you only fixed part of the issue.

Example:
bug_glotpress

If you look at the CSS, there's an invalid property:

table.translations td.original, table.translations td.translation {
    width: 45%;
    word-break: break-word;
    word-wrap: break-word;
}

If you replace word-break: break-word; with word-break: break-all it seems to fix it.

@toolstack toolstack self-assigned this Mar 15, 2018
@toolstack toolstack added the [Type] Bug An existing feature is broken. label Mar 15, 2018
@toolstack toolstack added this to the 3.0 milestone Mar 15, 2018
@toolstack toolstack added the [Status] In Progress Tracking issues with work in progress label Mar 15, 2018
@toolstack
Copy link
Contributor

There are a few places long words break the display of the wrapping (including in context strings as well), I think I've caught them all in #877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Projects
None yet
Development

No branches or pull requests

3 participants