Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing CompoundEdge implementations #60

Closed
Glusk opened this issue Apr 23, 2019 · 2 comments
Closed

Add missing CompoundEdge implementations #60

Glusk opened this issue Apr 23, 2019 · 2 comments

Comments

@Glusk
Copy link
Owner

Glusk commented Apr 23, 2019 •
edited
Loading

Replace next() methods in LocalRotations with NextCompoundEdge classes:

  • 2 versions next(a, b) and next(b)

ReversedEdge

  • input: original CompoundEdge and the RotationsList
@Glusk Glusk changed the title Add missing DirectedEdge implementations Add missing CompoundEdge implementations Apr 30, 2019
@Glusk
Copy link
Owner Author

Glusk commented Apr 30, 2019

ReversedEdge wass added in #65 with commit bd5d8b9

Glusk added a commit that referenced this issue Apr 30, 2019
@Glusk
#60 Added NextCompoundEdge impl. and its test class
467f471
Glusk added a commit that referenced this issue Apr 30, 2019
@Glusk
#60 Added proper direction color to ReversedCompundEdge
43b4570
@Glusk
Copy link
Owner Author

Glusk commented Apr 30, 2019

Build fails because LocalRotations#next() does not yet return an instance of a CompoundEdge

This was referenced Apr 30, 2019
Merged
Closed
Glusk added a commit that referenced this issue May 3, 2019
@Glusk
#60 Added CachedCompundEdge
2fdd56a
@Glusk Glusk mentioned this issue May 3, 2019
Merged
Glusk pushed a commit that referenced this issue May 3, 2019
Merge pull request #69 from Glusk2/cached-compound
bb96072 
#60 Added CachedCompundEdge
@Glusk Glusk closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Glusk