Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump dependencies versions #167

Closed
Glutexo opened this issue Jan 23, 2023 · 4 comments · Fixed by #213
Closed

⬆️ Bump dependencies versions #167

Glutexo opened this issue Jan 23, 2023 · 4 comments · Fixed by #213
Labels
dependencies Pull requests that update a dependency file

Comments

@Glutexo
Copy link
Owner

Glutexo commented Jan 23, 2023

Ensure all dependencies use their current latest stable version compatible with Elixir 1.10 if that version doesn’t break the code. This change may make sense only after introducing floki by #87. (Originally suggested in #87 (comment).)

@Glutexo Glutexo added the dependencies Pull requests that update a dependency file label Jan 23, 2023
@Glutexo Glutexo changed the title Bump dependencies versions ⬆️ Bump dependencies versions Jan 23, 2023
@Glutexo
Copy link
Owner Author

Glutexo commented Jan 23, 2023

Additional notes:

We list httpoison as ~> 1.8, not ~> 1.8.0. Although the Hex repository suggests this, I’d pin the minor version and only automatically upgrade the patch versions, which should not introduce breaking changes. Also, there is already a 2.0.0 version of the library, which is worth considering. (Update: it is safe to upgrade.)

mix.exs by the Mix website

mox already has a 1.0.2 version; our Mix lock file lists 1.0.1. mix.exs uses ~> 1.0, and as with httpoison, I suggest pinning to the patch version.

Elixir, specified as ~> 1.10, allows using a newer minor version. We downgraded to 1.10 to ensure compatibility with Debian. If we pinned dependencies to their minor versions, only allowing patch upgrades, shouldn’t the same apply to the language?

Also, does the reason for using such an old version still pertain, @nappex? Or are you ok with using a more modern one?

With a quick search, I couldn’t find any reliable source supporting my inclination towards allowing patch-level upgrades only. My justification is that patch versions introduce fixes (also security ones) but don’t change behavior. Feel free to object: I’d love to hear counter-arguments.

@Glutexo
Copy link
Owner Author

Glutexo commented Jan 24, 2023

I read the changelog for httpoison 2.0.0: it only changes how SSL options are processed. We don’t configure SSL by ourselves, so we can safely upgrade.

@nappex
Copy link
Collaborator

nappex commented Feb 5, 2023

Currently, we have a problem with Floki added in #87 , the latest version is 0.34.0. With our specification elixir dont want to update to 0.34.0 and keep 0.32.1

@Glutexo
Copy link
Owner Author

Glutexo commented Feb 24, 2024

Both @Glutexo and @nappex currently use Elixir 1.16.x. We don’t need to stick with 1.10, which we only retained because of Debian, which @nappex used to develop on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants