-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Fix flowchart alignment #109
Conversation
The aligning whitespace is pretty but hardly sustainable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was made for better readability, do you think it has not a worth?
It certainly had with the very first version of the flowchart. Now, if you want to amend it, you need to reformat whitespace on all the lines, which seems rather impractical. Just look how broken it was before this Pull Request. The position of the top and bottom arrows is off, and so is the alignment of the right side.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, flowchart is not so complicated... to stick on the readability.
Align the flowchart sides and arrows instead of collapsing the whitespace.
Instead of collapsing the whitespace, I cleaned up the aligned version. Although it looks nice, I am afraid the maintainability won’t be high. But we can revisit the formatting once it becomes a real problem. Thank you for your input! |
Aligned the flowchart sides and arrows.