Use default argument for load_urls #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the logic of load_urls input in this function. Leverage default argument values to achieve this. As a result, the download/2 function is simplified.
nappex
reviewed
Feb 13, 2022
Comment on lines
+34
to
+35
| def load_urls(path \\ nil) | ||
|
|
There was a problem hiding this comment.
Hmm I am confused what does it mean. Do you have some material or docs where did you find this approach, please?
There was a problem hiding this comment.
It’s a default argument. See https://hexdocs.pm/elixir/Kernel.html#def/2-default-arguments. Again, it is a syntactic sugar for multiple functions of the same name.
|
Closing without merging. I don’t want to do this any more. Feel free to comment or reopen. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the logic of load_urls input in this function. Leverage default argument values to achieve this. As a result, the
download/2function is simplified.