Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove download_urls/3 #67

Merged
merged 4 commits into from
Feb 19, 2022
Merged

Remove download_urls/3 #67

merged 4 commits into from
Feb 19, 2022

Commits on Feb 12, 2022

  1. Remove download/3 with urls as list

    Enumerable traversal is a trivial concept. It does not make sense to
    have a separate function just to do Enum.map. It brings confusing
    function dichotomy and a need for guard clauses. Also it discourages
    from using other types of enumerables like streams.
    
    For the function to be testable, the get_env call needed to be moved
    to main/0, which makes nice symmetry with http_client. Because the
    input_path parameter is of the same type and thus indistiguishable
    from a URL, it only makes sense to rename the function.
    Glutexo committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    d75ce27 View commit details
    Browse the repository at this point in the history
  2. Removed the get_env move

    Reverted the get_env move to minimize the amount of changes. Used
    Enum.map in the malfunctioning “download URLs from the input file”
    test to at least make it still download all the URLs.
    Glutexo committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    8895fef View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2022

  1. Configuration menu
    Copy the full SHA
    e5e1fad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    278d1e0 View commit details
    Browse the repository at this point in the history