Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Rename get! to prepare_response #78

Merged
merged 2 commits into from
Feb 25, 2022
Merged

♻️ Rename get! to prepare_response #78

merged 2 commits into from
Feb 25, 2022

Conversation

Glutexo
Copy link
Owner

@Glutexo Glutexo commented Feb 19, 2022

The function became being used in other places than in HTTPoison.get!/3 mocks. Used prepare_ for symmetry with
prepare_input/1.

Fixes #75.

The function became being used in other places than in
HTTPoison.get!/3 mocks. Used prepare_ for symmetry with
prepare_input/1.
@Glutexo
Copy link
Owner Author

Glutexo commented Feb 19, 2022

I don’t like the prepare_ much, but I couldn’t come up with anything better.

@Glutexo Glutexo changed the title Rename get! to prepare_response ♻️ Rename get! to prepare_response Feb 20, 2022
@Glutexo
Copy link
Owner Author

Glutexo commented Feb 20, 2022

Merged current elixir and resolved conflicts.

@nappex nappex merged commit 4a1e40c into elixir Feb 25, 2022
@nappex nappex deleted the prepare_response branch February 25, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename get! to something as prepare_response
2 participants