Add support for setting the OpenGL version #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed the explicit GLFW.Init()/GLFW.Terminate() calls since GLFW will do that automatically.
|
(if there's no objections I'll merge this in the next few days) |
|
I don't know if we would need several backends, but it looks good. |
|
Do you mean like for SDL etc? Yeah some options may eventually be specific to their backends, at that point we'll just have to document them as such. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed the explicit GLFW.Init()/GLFW.Terminate() calls since GLFW will do that automatically.
@Gnimuc, @sairus7, does this look reasonable? I tried to preserve the previous behaviour, except for defaulting to OpenGL 3.2 on non-OSX systems.