Update wrapper.jl #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I have seen a deadlock from calling `lbfgsb` many times with multi-threaded code inside `jupyter` notebooks. I have not been able to produce a MWE to submit a reliable test here, but I have been able to fix locally with the `flush(stdout)` commands added above. I know this may be a poor justification for the PR, but the above commands can't hurt (hopefully) :) Cheers!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have seen a deadlock from calling
lbfgsbmany times with multi-threaded code insidejupyternotebooks. I have not been able to produce a MWE to submit a reliable test here, but I have been able to fix locally with theflush(stdout)commands added above.It only happens when
iprint=1and there would be a lot of printing, which made me suspect buffered IO and try the solution submitted here.I know this may be a poor justification for the PR, but the above commands can't hurt (hopefully) :)
Cheers!