Fixed Enforcer defaulting to default skills on start-up, even if alternate skills were chosen before closing the game. #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause:
Enforcer's Skills and SkillFamilies are not named, causing them to not save in the UserProfile correctly. They're recorded as having the SkillFamily name "" and skillname "" (both blank).
(The XML file is all one line, I indented it in this comparison so it's not difficult to understand).
Normal Families are saved as (For Example, Artificer):
THUNDERSTORE VERSION:
MY FIX:
Meanwhile, Manipulator by ValeX:
The game is actually saving it correctly. SkillFamily "" and SkillName "" are getting stored.
The issue is that their names aren't changed. Turns out that for a SkillDef, the
skillName
and thename
are pretty much seperate.So I added
to
RegisterSkillDef
so that it auto names the skills (simplyskillDef.name
is obsoleted due to allocations).For the SkillFamilies, I did basically the same thing as a simple adjustment due to me being unfamiliar with the codebase (as in preventing me from naming each skillFamily as like EnforcerPrimary EnforcerSecondary, you can do this simple too by using a switch case and a modulus; I didn't because it felt unneeded for this quick fix)