stock assistant - add units column, remove zero-fee line #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christopherlam
commented
Sep 6, 2022
christopherlam
commented
- add stock units column indicating gain/loss of number of units
- don't show Fee line if zero; a zero-fee split isn't generated.
christopherlam
changed the title
christopherlam
force-pushed
the
maint-stock-transaction-summary
branch
from
dd7c48f
to
69e2c59
Compare
christopherlam
added a commit
to christopherlam/gnucash
that referenced
this pull request
Sep 7, 2022
rename SPLIT_COL_MEMO_ESCAPED to SPLIT_COL_TOOLIP
... This will be useful for adding Units column
christopherlam
force-pushed
the
maint-stock-transaction-summary
branch
from
69e2c59
to
c6472e5
Compare
|
It uses the existing string "Units" so I think it's ok to merge. |
jralls
reviewed
Sep 9, 2022
jralls
requested changes
Sep 9, 2022
Pull out add_to_summary_table function to populate the summary_info. Preparation for next commit
refactor; refresh_page_finish calls add_to_summary_table instead of check_page.
christopherlam
force-pushed
the
maint-stock-transaction-summary
branch
from
c6472e5
to
eab8a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.