GoQZipCodeのユニットテストを部分的に作成 #34
Open
+1,822
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mori-goq
reviewed
May 7, 2024
|
@mori-goq |
|
@marumoto-goq |
|
@mori-goq |
mori-goq
reviewed
May 8, 2024
nagaoka-goq
reviewed
May 15, 2024
src/test/utils/checkLength.test.ts
Outdated
Comment on lines
19
to
21
| expect(checkLength(false, 4)).toBe(true); | ||
| expect(checkLength(false, 8)).toBe(true); | ||
| expect(checkLength(false, 10)).toBe(true); |
There was a problem hiding this comment.
@marumoto-goq
こういうのはあまり意味ないと思っていて、2以上であれば2と3だけテストが通ることを確認したらいいと思っている。
これを読むとよい。
mori-goq
reviewed
May 31, 2024
|
@mori-goq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更の概要
GoQZipCodeのテスト作成にあたり部分的にユニットテストを作成しました。
変更の内容
やったこと