Added Windows support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Res260
reviewed
Jul 5, 2019
Res260
approved these changes
Jul 5, 2019
xshill
reviewed
Jul 22, 2019
README.md
Outdated
| @@ -52,7 +52,7 @@ PyRDP was [first introduced in a blogpost](https://www.gosecure.net/blog/2018/12 | |||
| ## Supported Systems | |||
| PyRDP should work on Python 3.6 and up. | |||
|
|
|||
| This tool has been tested to work on Python 3.6 on Linux (Ubuntu 18.04). It has not been tested on OSX and Windows. | |||
| This tool has been tested to work on Python 3.6 on Linux (Ubuntu 18.04). It has not been tested on OSX. | |||
There was a problem hiding this comment.
Do you mean "tested to work on Linux [...] and Windows"?
|
@xshill Sorry for the delay, went all-in on the crawler lol, should be good now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in #127, I removed Notify2 and dbus references when using Windows. I also moved "Installing on Windows" up a notch in the README, since that we can now actually install it without any hacks.
I have tested on a brand new environment without any problems. Note that this PR won't work on Windows without #128, but since they are really distinct I think they should be kept apart.