Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with PDU handling in headless mode #446

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robeving
Copy link
Contributor

This fixes a bug with headless replay of files, specifically those created by pyrdp-convert.py which seems to set the timestamp to 0. Using the timestamp is probably bad anyway due to the risk of collision.

@robeving
Copy link
Contributor Author

Fixes #445

@obilodeau
Copy link
Collaborator

This fix artificially accelerates all replays when played in pyrdp-player.py because it squeezes all events together leaving no silence between events. It cannot be merged like that.

@obilodeau obilodeau added invalid This doesn't seem right investigate Needs more thought / experience labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right investigate Needs more thought / experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants