Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wakes-0.2.4 crash (on Vulkan mod?) #69

Open
Zorklis opened this issue Apr 15, 2024 · 11 comments
Open

wakes-0.2.4 crash (on Vulkan mod?) #69

Zorklis opened this issue Apr 15, 2024 · 11 comments
Labels
bug Something isn't working crash Causes the game to crash incompatibility Issue may be related to another mod/datapack etc.

Comments

@Zorklis
Copy link

Zorklis commented Apr 15, 2024

Describe the bug
Crashed on world load, Few seconds in.

Expected behavior
No crashy

To Reproduce
Try with Vulkan?

Screenshots

Hardware and OS
W10

Versions

  • Minecraft version - 1.20.4
  • Fabric loader - 0.15.10
  • Wakes version - 0.2.4
  • Fabric API version - 0.97.0

Additional information
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_5944.method_34586()" because "shaderInstance" is null
at net.minecraft.class_286.method_43433(class_286.java:1041)
at net.minecraft.class_289.method_1350(class_289.java:41)
at com.goby56.wakes.render.DynamicWakeTexture.render(DynamicWakeTexture.java:93)
at com.goby56.wakes.render.WakeTextureRenderer.afterTranslucent(WakeTextureRenderer.java:53)
at net.fabricmc.fabric.api.client.rendering.v1.WorldRenderEvents.lambda$static$22(WorldRenderEvents.java:222)
at net.minecraft.class_761.handler$cli000$fabric-rendering-v1$beforeClouds(class_761.java:6860)
at net.minecraft.class_761.method_22710(class_761.java:1283)
at net.minecraft.class_757.method_3188(class_757.java:1098)
at net.minecraft.class_757.method_3192(class_757.java:866)
at net.minecraft.class_310.method_1523(class_310.java:1327)
at net.minecraft.class_310.method_1514(class_310.java:888)
at net.minecraft.client.main.Main.main(Main.java:265)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

@Zorklis Zorklis added the bug Something isn't working label Apr 15, 2024
@Rhett008
Copy link

Rhett008 commented Apr 18, 2024

Wakes is listed as incompatible with Vulkan in their list. I would recommend just using Sodium

@Zorklis
Copy link
Author

Zorklis commented Apr 18, 2024

Wakes is listed as incompatible with Vulkan in their list. I would recommend just using Sodium

What list are you talking about?

No I will not "just use Sodium", Sodium while better than Vanilla, SUCKS! I can max out my Minecraft settings AND have X32 render distance on Vulkan mod, with no stutters.
(On GTX 1060 6GB + i7 3770k)

@Zorklis
Copy link
Author

Zorklis commented Apr 18, 2024

Also Wakes 0.2.2 didn't have this crash, but it's effect was broken

@KennyDevT
Copy link

KennyDevT commented Apr 20, 2024

No I will not "just use Sodium", Sodium while better than Vanilla, SUCKS! I can max out my Minecraft settings AND have X32 render distance on Vulkan mod, with no stutters.

  1. Weird. it shouldn't be that much of a difference
  2. Use Embeddium or Nvidium

@Zorklis
Copy link
Author

Zorklis commented Apr 21, 2024

1. Weird. it shouldn't be that much of a difference

Yet it is. Also why wouldn't it be a difference, Vanilla is using old libraries while Vulkan mod uses Vulkan which is much newer and more efficient.

2. Use Embeddium or Nvidium

?
So you saw my comment and that it said I have a gtx 1060 and you suggest a mod (Nvidium) that requires anything that is a "16xx series or newer (20xx series also works) that supports mesh shaders."
So a mod that's not supported..
Can this thread stay on topic, which is on Wakes crashing.

@KennyDevT
Copy link

The visuals were already broken so the fact that it's broken now is not very surprising Screenshot_20240420_220406_Chrome.jpg

@Zorklis
Copy link
Author

Zorklis commented Apr 21, 2024

The visuals were already broken so the fact that it's broken now is not very surprising

Thanks for stating the same thing I said three days ago.. in this same thread.
#69 (comment)

@Rhett008
Copy link

Rhett008 commented May 9, 2024

Calm down mate. Probably not going to get help being rude. Just trying to help find a solution.

Sodium works perfectly for me, it's very compatible and works with Wakes + shaders. You also might be able to max out your settings and render distance while staying above 100fps, like I do.

Vulkan seems to be incompatible with a lot of mods - I wouldn't call it a renderer with a lot of worth in that case. Pretty much everything on fabric is compatible with Sodium because mods are made to work beside it. Here's the list of Vulkan's incompatibilities: xCollateral/VulkanMod#226

Since visuals were broken with Wakes 0.2.2, it's a given that Vulkan could not be compatible with the current version of Wakes thus causing crashes. This could be due to an update of code or features to either mod, thus rolling back to different versions may fix the issue.

@Zorklis
Copy link
Author

Zorklis commented May 9, 2024

Calm down mate. Probably not going to get help being rude. Just trying to help find a solution.

You coming here with mods I am already well aware of is not gonna help this..

Sodium works perfectly for me, it's very compatible and works with Wakes + shaders. You also might be able to max out your settings and render distance while staying above 100fps, like I do.

Again, I am aware of my fps with Sodium vs Vulkan and Vulkan mod wins.

Vulkan seems to be incompatible with a lot of mods - I wouldn't call it a renderer with a lot of worth in that case. Pretty much everything on fabric is compatible with Sodium because mods are made to work beside it. Here's the list of Vulkan's incompatibilities: xCollateral/VulkanMod#226

I've been testing mods with Vulkan since 2022 and have my own compatibility mod list, that other great people contribute to.
xCollateral/VulkanMod#46 and I am well aware of the other list. I don't understand why you gotta come here and mansplain your side when you haven't done as much testing as I have and you probably have much higher specs than I do (so does KennyDevT it seems) so you don't notice the performance hits as much as me or someone else with low-end hardware.

Since visuals were broken with Wakes 0.2.2, it's a given that Vulkan could not be compatible with the current version of Wakes thus causing crashes. This could be due to an update of code or features to either mod, thus rolling back to different versions may fix the issue.

Of course it's due to an updated code. I would not recommend anyone to roll back to a lower version of Vulkan since the newer the version is, the better the performance and compatibility with mods is. It's a Wakes issue and I understand if Goby56 does not wanna partake in researching what causes this at this time.
Anyways I hope you stop "recommending" and unless you provide a crash log or something to fix this, to not comment further. Have a nice day.

@Rhett008
Copy link

Alright well, it seems as if I can't give my free time services here.

Not everything I say may be correct but I'm guessing if your attitude was less autocratic, the mod developer may even consider helping you out with your crash.

Have a nice day.

@Zorklis
Copy link
Author

Zorklis commented May 11, 2024

Alright well, it seems as if I can't give my free time services here.

Not everything I say may be correct but I'm guessing if your attitude was less autocratic, the mod developer may even consider helping you out with your crash.

You're the ass here. I keep saying I don't need your opinions, yet you keep showing up.
I notified them about the issue, that's all I did, but you're the one who isn't okay with people choosing something else than Sodium.
P.S. if you're not sure that your free service is of value, maybe don't show up..

@Goby56 Goby56 added incompatibility Issue may be related to another mod/datapack etc. crash Causes the game to crash labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash Causes the game to crash incompatibility Issue may be related to another mod/datapack etc.
Projects
None yet
Development

No branches or pull requests

4 participants