Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed physics hand bone groups #428

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Fixed physics hand bone groups #428

merged 1 commit into from
Mar 31, 2023

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request fixes issue #427 by:

  • Fixing XRToolsHandPhysicsBone names from godot 3 import.
  • Fixing bone group names for LeftHand and RightHand.
  • Fixing bone group names for IndexFinger.

@Malcolmnixon
Fixed XRToolsHandPhysicsBone names from godot 3 import.
37bd906 
Fixed bone group names for LeftHand and RightHand.
Fixed bone group names for IndexFinger.
DigitalN8m4r3
DigitalN8m4r3 approved these changes Mar 26, 2023
View reviewed changes
Copy link
Contributor

@DigitalN8m4r3 DigitalN8m4r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
and good catch @Malcolmnixon

BastiaanOlij
BastiaanOlij approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Malcolmnixon Malcolmnixon merged commit 7babc68 into GodotVR:master Mar 31, 2023
@Malcolmnixon Malcolmnixon deleted the hand-bone-groups branch March 31, 2023 15:27
@BastiaanOlij BastiaanOlij added this to the 4.1.0 milestone Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

@DigitalN8m4r3 DigitalN8m4r3 DigitalN8m4r3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Malcolmnixon @BastiaanOlij @DigitalN8m4r3