Added Flight movement provider #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Flight movement provider Removed flying from Direct movement provider Modified Glide movement provider default order to be after flight
Malcolmnixon
force-pushed
the
flight_movement
branch
from
79d0dfd
to
0d99be1
Compare
|
|
||
|
|
||
| # enum our buttons, should find a way to put this more central | ||
| enum Buttons { |
There was a problem hiding this comment.
@Malcolmnixon probably not for this PR but maybe a separate one, we should look into moving this into our util script so these enums are just available
|
Looks great! Let me know if you're ready for this to be merged |
|
I think this one's ready to go in. Flight has such a diverse set of possibilities that I'm certain we'll get many requests for new features as people get a chance to play. Some we may be able to fit in, but many where it's better served by a game-specific customized script. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issues #79 and #80.