Merge GDExtension into a single implementation #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
force-pushed
the
single_gdextension
branch
4 times, most recently
from
8ad906c
to
342b327
Compare
dsnopek
approved these changes
Feb 2, 2024
m4gr3d
force-pushed
the
single_gdextension
branch
5 times, most recently
from
831c8e0
to
2c455ca
Compare
Move all the gdextension logic intom the `common` directory so to share the same functionality across all vendors. For the editor, this enables a single `scons` build file and a single gdextension that can be loaded by the editor. For Android vendor platforms, we still maintains separate `cmake` build files which allows to omit / include platform specific dependencies via pre-processor directives in order to generate platform specific shared libraries, which are included in platform specific AAR binaries.
m4gr3d
force-pushed
the
single_gdextension
branch
from
2c455ca
to
243c9c7
Compare
|
I just built and tested this locally and it seems to be working great! |
Thanks! I'll go ahead and merge the changes. @BastiaanOlij Feel free to add any comments / feedback if you have any and I'll address them in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the gdextension logic into the
commondirectory so to share the same functionality across all vendors.For the editor, this enables a single
sconsbuild file and a single gdextension that can be loaded by the editor.For Android vendor platforms, we still maintains separate
cmakebuild files which allows to omit / include platform specific dependencies via pre-processor directives in order to generate platform specific shared libraries, which are included in platform specific AAR binaries.Fixes #70