Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Non-interactive use of script #442

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

stablestud
Copy link
Contributor

@stablestud stablestud commented May 29, 2024

This commit improves Gogh security and usage when being used non-interactively (for usage with scripts)

It includes not only one but multiple improvements:

  • Close potential backdoor by removing downloading of files from remote servers
    • Instead files must be downloaded manually beforehand when using theme shell scripts directly
    • gogh.sh is unaffected, it will download the files
  • Remove hardcoded path for apply scripts in theme shell scripts (was parent dir)
    • Instead the path to the apply scripts can be set by following environmental variables
      • GOGH_APPLY_SCRIPT
      • GOGH_TERMINATOR_SCRIPT
      • GOGH_ALACRITTY_SCRIPT
    • Fallback to old behavior if no path was given
  • Add missing Python requirement for Terminator script
  • Add additional .gitignore files to cover Vim swap files and Python virtual environment

I could split up the commit into 3 smaller ones, but the GOGH_* environment feature and removal of file downloading is closely coupled and therefore cannot be split up into smaller commits.

@stablestud
Copy link
Contributor Author

I fixed a bug in the theme shell scripts, therefore I had to update the commit. Should be all set now :)

@Mgldvd Mgldvd merged commit 50be184 into Gogh-Co:master May 30, 2024
@Mgldvd
Copy link
Collaborator

Mgldvd commented May 30, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants