Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #111

Merged
merged 53 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
ec0aeb3
fix social links and show only if available
krisbitney Jan 13, 2024
a229937
changed DonorListItem amount display from toFixed to toString
krisbitney Jan 13, 2024
5b5ea2d
sort connectors with WalletConnect before MetaMask
krisbitney Jan 13, 2024
5bf352c
added token symbol next to wallet balance and adjusted balance format…
krisbitney Jan 13, 2024
97c3686
update copy for on-time donation, added chain check to useEthersSigne…
krisbitney Jan 13, 2024
de210a0
one-time transfer now assumes token is already approved for transfer
krisbitney Jan 13, 2024
62f98f7
G$ donation now assumes token is already approved for transfer
krisbitney Jan 13, 2024
f7c8708
added infoButton property to ipfs meta data in subgraph
krisbitney Jan 13, 2024
0621868
increased slippage tolerance from 0.5% to 1%
krisbitney Jan 13, 2024
2340134
made it so only G$ shows in token list for one-time donations
krisbitney Jan 13, 2024
8509965
made it so selecting one-time donation changes currency to G$ and amo…
krisbitney Jan 13, 2024
944b7f3
fixed total donation usd value
krisbitney Jan 13, 2024
4be3b2e
swap errors will only show if donation amount is not zero
krisbitney Jan 13, 2024
70115a4
added infoLabel to front end
krisbitney Jan 13, 2024
61e129e
updated breadcrumb to show collective name and only go back to previo…
krisbitney Jan 13, 2024
c2f7412
updated breadcrumb to fix links and text
krisbitney Jan 13, 2024
42c5e4e
incremented subgraph starting block because prior block was failing
krisbitney Jan 13, 2024
ed70f56
donation is now disabled if swap required and token approval not yet …
krisbitney Jan 13, 2024
4a7fb25
breadcrumb formatting for '/'
krisbitney Jan 13, 2024
e9ce60c
adjusted G$ formatting in profile
krisbitney Jan 13, 2024
87dd162
modal and donation error formatting
krisbitney Jan 13, 2024
380eef8
added steward profile link to steward list item
krisbitney Jan 13, 2024
0d25888
added polling to donor in wallet; improved error message in donation …
krisbitney Jan 13, 2024
fa5314c
fix for error message in donation functions
krisbitney Jan 13, 2024
b115063
switched from supportSingleTransferAndCall to supportSingleBatch sinc…
krisbitney Jan 13, 2024
2009037
removed warnings for missing subgraph items
krisbitney Jan 13, 2024
527a3aa
set margin between collective cards on home page to 24
krisbitney Jan 13, 2024
c8d45d1
fixed transaction list UI
krisbitney Jan 14, 2024
3fe72fd
added useRecentTransactions hook
krisbitney Jan 14, 2024
124ddbe
fixed ViewCollective tablet portrait resolution
krisbitney Jan 14, 2024
3f2fa75
removed G$ fractional amount from connected wallet display, and added…
krisbitney Jan 14, 2024
aaf2a64
made sure G$ displayed amount is rounded down to nearest int
krisbitney Jan 14, 2024
9101bc2
fixed stop donation
krisbitney Jan 14, 2024
647653c
changed default gas price to 5 in @gooddollar/goodcollective-sdk
krisbitney Jan 14, 2024
6a84def
renamed enum value from celo to CELO
krisbitney Jan 14, 2024
93e55ab
currentPool is now a flowing balance
krisbitney Jan 14, 2024
d48eb53
refactor: dry up donate button styles, no inline arrow functions
L03TJ3 Jan 14, 2024
872f831
fix: getDonateStyles, does not stop loop after hitting first true
L03TJ3 Jan 14, 2024
0e7106c
fix: simplify getDonateStyles
L03TJ3 Jan 14, 2024
bdd7a25
inline lambdas to const
krisbitney Jan 15, 2024
ba8681e
memoized onChangeFrequency
krisbitney Jan 15, 2024
1f147c8
fixed link to smart contract in ViewCollective
krisbitney Jan 15, 2024
0c1f6a0
version bump
L03TJ3 Jan 15, 2024
2dee3d8
version bump
L03TJ3 Jan 15, 2024
8960bf6
version bump
L03TJ3 Jan 15, 2024
111f1a3
version bump
L03TJ3 Jan 15, 2024
1b7ae7e
version bump
L03TJ3 Jan 15, 2024
48c5097
version bump
L03TJ3 Jan 15, 2024
5a85fe1
version bump
L03TJ3 Jan 15, 2024
aade2c4
version bump
L03TJ3 Jan 15, 2024
79d8a9c
version bump
L03TJ3 Jan 15, 2024
f8777ff
chore: release sdk, bump in app
L03TJ3 Jan 15, 2024
a3c7e31
Merge branch 'web3Integrations' of github.com:GoodDollar/GoodCollecti…
L03TJ3 Jan 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .yarn/versions/a125cec7.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
undecided:
- "@gooddollar/goodcollective"
- "@gooddollar/goodcollective-app"
- "@gooddollar/goodcollective-contracts"
- "@scaffold-eth/subgraph"
2 changes: 1 addition & 1 deletion packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@celo-tools/celo-ethers-wrapper": "^0.4.0",
"@ethersproject/shims": "^5.7.0",
"@gooddollar/good-design": "^0.1.31",
"@gooddollar/goodcollective-sdk": "^1.0.6",
"@gooddollar/goodcollective-sdk": "^1.0.15",
"@gooddollar/web3sdk-v2": "^0.2.2",
"@react-native-aria/interactions": "0.2.3",
"@react-native-async-storage/async-storage": "^1.18.2",
Expand Down
9 changes: 4 additions & 5 deletions packages/app/src/components/ApproveSwapModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,7 @@ const ApproveSwapModal = ({ openModal, setOpenModal }: AproveSwapModalProps) =>
<View style={styles.centeredView}>
<View style={styles.modalView}>
<View style={modalStyles.modalCloseIconWrapper}>
<TouchableOpacity
style={modalStyles.modalCloseIcon}
onPress={() => {
setOpenModal(false);
}}>
<TouchableOpacity style={modalStyles.modalCloseIcon} onPress={() => setOpenModal(false)}>
<Image source={CloseIcon} style={styles.closeIcon} />
</TouchableOpacity>
</View>
Expand All @@ -45,6 +41,9 @@ const styles = StyleSheet.create({
marginTop: 22,
},
modalView: {
maxWidth: '90%',
maxHeight: '90%',
overflowY: 'scroll',
margin: 20,
backgroundColor: Colors.blue[100],
borderRadius: 20,
Expand Down
36 changes: 27 additions & 9 deletions packages/app/src/components/Breadcrumb.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,36 @@ import { Colors } from '../utils/colors';
import { useNavigate } from 'react-router-dom';
import { chevronRight } from '../assets';

export interface BreadcrumbPathEntry {
text: string;
route: string;
}

interface BreadcrumbProps {
previousPage?: string;
currentPage: string;
path: BreadcrumbPathEntry[];
}

function Breadcrumb({ currentPage, previousPage }: BreadcrumbProps) {
function Breadcrumb({ path }: BreadcrumbProps) {
const navigate = useNavigate();
const onClickBack = () => navigate(-1);
const onClickHome = () => navigate('/');

return (
<TouchableOpacity style={styles.container} onPress={() => navigate(-1)}>
<Image source={chevronRight} style={styles.backIcon} />
<Text style={styles.activePage}>{previousPage ?? 'GoodCollective Home'}</Text>
<Text style={styles.nextPage}> / {currentPage}</Text>
<TouchableOpacity style={styles.container}>
<TouchableOpacity onPress={onClickBack}>
<Image source={chevronRight} style={styles.backIcon} />
</TouchableOpacity>
<Text style={path.length === 0 ? styles.activePage : styles.previousPage} onPress={onClickHome}>
GoodCollective Home
</Text>
{path.map((entry, index) => (
<Text
key={index}
style={index === path.length - 1 ? styles.activePage : styles.previousPage}
onPress={() => navigate(entry.route)}>
{` / ${entry.text}`}
</Text>
))}
</TouchableOpacity>
);
}
Expand All @@ -26,8 +44,8 @@ const styles = StyleSheet.create({
flexDirection: 'row',
marginBottom: 12,
},
activePage: { color: Colors.purple[200] },
nextPage: { color: Colors.gray[200] },
previousPage: { color: Colors.purple[200] },
activePage: { color: Colors.gray[200] },
backIcon: {
width: 20,
height: 20,
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/components/CollectiveHomeCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const styles = StyleSheet.create({
cardContainerDesktop: {
width: 360,
height: 330,
margin: 32,
marginBottom: 0,
},
cardTitle: {
fontSize: 20,
Expand Down
14 changes: 7 additions & 7 deletions packages/app/src/components/CompleteDonationModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,22 @@ interface CompleteDonationModalProps {
}

const CompleteDonationModal = ({ openModal, setOpenModal }: CompleteDonationModalProps) => {
// const { navigate } = useCrossNavigate();
const onClickClose = () => setOpenModal(false);

return (
<View style={styles.centeredView}>
<Modal animationType="slide" transparent={true} visible={openModal}>
<View style={styles.centeredView}>
<View style={styles.modalView}>
<View style={modalStyles.modalCloseIconWrapper}>
<TouchableOpacity
style={modalStyles.modalCloseIcon}
onPress={() => {
setOpenModal(false);
}}>
<TouchableOpacity style={modalStyles.modalCloseIcon} onPress={onClickClose}>
<Image source={CloseIcon} style={styles.closeIcon} />
</TouchableOpacity>
</View>
<Text style={styles.title}>COMPLETE YOUR DONATION</Text>
<Text style={styles.paragraph}>To complete your donation, sign with your wallet.</Text>
<Image source={PhoneImg} alt="woman" style={styles.image} />
<TouchableOpacity style={styles.button} onPress={() => setOpenModal(false)}>
<TouchableOpacity style={styles.button} onPress={onClickClose}>
<Text style={styles.buttonText}>OK</Text>
</TouchableOpacity>
</View>
Expand All @@ -47,6 +44,9 @@ const styles = StyleSheet.create({
marginTop: 22,
},
modalView: {
maxWidth: '90%',
maxHeight: '90%',
overflowY: 'scroll',
margin: 20,
backgroundColor: Colors.blue[100],
borderRadius: 20,
Expand Down
Loading
Loading