-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AxiosError: syncTxFromExplorer failed: Network Error #4175
Comments
@johnsmith-gooddollar we are prioritizing this for sprint 6 - can you confirm you are accountable and will own this ticket? |
Should we log or not? @johnsmith-gooddollar @sirpy syncFromExplorer:
Something with codepusH?: codepush-event and the question.. should we completely hide network errors from logging: #4192 |
@L03TJ3 warnings are irrelevant we are only talking about errors which are logged to sentry. @johnsmith-gooddollar @L03TJ3 if we can log the url that failed it might make more sense, and also perhaps make sure we log the url only once per session/refresh |
@sirpy if any errors are caused by due to faulty rpc errors and are not picked up by any other the faulty rpc's will be shown in the stack trace on sentry still. no need to log them all imo The ones regularly complaining about threshold are: at least the ones I noticed |
@L03TJ3 if for example we put a wrong rpc address with a typo, the logger will ignore any errors with this rpc. |
@sirpy besides that, what I now see is that any error/warning has been silenced and wrapped with !isConnectionError, so whatever meant is not usefull anyway reference which warnings I would expect to see in a stack strace:
|
@johnsmith-gooddollar can we do that? log url that failed once? |
@sirpy @L03TJ3 After some additional research I've found it's not easy to do a) we could get failed URL from axios error In the other cases (e.g. failed fetch() to XMLHTTPRequest() from some liberary like realmdb) we cannot obtain url has failed with the network error. So what I've done |
@johnsmith-gooddollar |
Fixed
Fixed |
|
@vldkhh verify on prod |
@vldkhh I think this can be rechecked as well |
I've merged 4 network error issues to this one (you can see them by clicking the merged issues tab in sentry)
Can we safely ignore and not report Network error and network request error?
Sentry Issue: GOODDAPP-5VXW
The text was updated successfully, but these errors were encountered: