Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Chore) Log network errors once per session/refresh #4211

Merged
merged 6 commits into from
Feb 5, 2024
Merged

(Chore) Log network errors once per session/refresh #4211

merged 6 commits into from
Feb 5, 2024

Conversation

johnsmith-gooddollar
Copy link
Collaborator

Description

  • ignore network errors at log.error globally
  • add log.exception as alias of the old one log.error without changes
  • log http provider and axis network errors once per session/reload per each rpc url / full request url correspondingly

About #4175

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 7:20am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
gooddollar-delta ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2024 7:20am
goodid ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2024 7:20am

@johnsmith-gooddollar johnsmith-gooddollar linked an issue Feb 1, 2024 that may be closed by this pull request
AxiosError: syncTxFromExplorer failed: Network Error #4175
Closed
@johnsmith-gooddollar johnsmith-gooddollar mentioned this pull request Feb 1, 2024
Closed
@johnsmith-gooddollar johnsmith-gooddollar merged commit 6c88f2b into master Feb 5, 2024
18 of 20 checks passed
@johnsmith-gooddollar johnsmith-gooddollar deleted the 4175-sync-tx-with-explorer branch February 5, 2024 09:53
sirpy added a commit that referenced this pull request Feb 8, 2024
@sirpy
Squashed commit of the following:
d0ea601 
commit 30e1f3d
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Feb 8 15:10:39 2024 +0000

    chore: release qa version 2.33.1-1 [skip build]

commit 81f0e94
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Feb 8 23:09:21 2024 +0800

    fix: snapshots

commit 5f3fad8
Merge: 3519e18 3f84cfa
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Feb 8 22:42:43 2024 +0800

    Merge branch 'master' of github.com:GoodDollar/GoodDAPP

commit 3519e18
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Feb 8 22:41:29 2024 +0800

    bump wallet-chat

commit 3f84cfa
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Feb 8 14:29:07 2024 +0000

    chore: release qa version 2.33.1-0 [skip build]

commit 2612971
Author: LewisB <lewis@gooddollar.org>
Date:   Wed Feb 7 15:46:36 2024 +0800

    fix: move tokensymbol to amount

commit 96ca3fc
Merge: bfa12e2 6c88f2b
Author: LewisB <lewis@gooddollar.org>
Date:   Wed Feb 7 01:13:27 2024 +0800

    Merge branch 'master' of github.com:GoodDollar/GoodDAPP

commit 6c88f2b
Author: johnsmith-gooddollar <89783679+johnsmith-gooddollar@users.noreply.github.com>
Date:   Mon Feb 5 11:53:15 2024 +0200

    (Chore) Log network errors once per session/refresh (#4211)

    * revert log.error at wallet class, add global errors filtering

    * add log axios errors once

    * add log http providers once

    * apply changes requested

    * Update src/lib/wallet/MultipleHttpProvider.js

    ---------

    Co-authored-by: sirpy <hadar@gooddollar.org>

commit bfa12e2
Merge: 63267b5 db59b61
Author: LewisB <lewis@gooddollar.org>
Date:   Fri Feb 2 20:20:34 2024 +0800

    Merge branch 'master' of github.com:GoodDollar/GoodDAPP

commit db59b61
Author: LewisB <lewis@gooddollar.org>
Date:   Wed Jan 31 22:05:25 2024 +0800

    fix: typo in next-tasks feature-flag

commit 63267b5
Author: LewisB <lewis@gooddollar.org>
Date:   Wed Jan 31 22:05:25 2024 +0800

    fix: typo in next-tasks feature-flag

commit 224e35c
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 14:30:21 2024 +0200

    add log http providers once

commit b3db632
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 14:21:53 2024 +0200

    add log axios errors once

commit 8af89dd
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 14:09:58 2024 +0200

    revert log.error at wallet class, add global errors filtering

commit 509c78a
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 13:16:10 2024 +0200

    hotfix: logError

commit 94ead3d
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 13:07:25 2024 +0200

    make gtag snippet looking exactly as example from docs

commit 5375f31
Author: Lewis B <laurence@gooddollar.org>
Date:   Tue Jan 30 13:52:18 2024 +0800

    fix: replace dataLayer with  gtag in GoogleWrapper (#4209)

    * fix: replace dataLayer with  gtag in GoogleWrapper

    * fix: implement gtag correctly

commit 4e98a61
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 22:11:57 2024 +0800

    add: log, increase poll time for receipt to align with block time

commit 91109b9
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Jan 25 14:05:12 2024 +0000

    chore: release prod version 2.33.0 [skip build]

commit d0d4e64
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Jan 25 12:17:10 2024 +0000

    chore: release qa version 2.32.1-1 [skip build]

commit bbfd3ec
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 19:53:52 2024 +0800

    fix: snaps after running blockchainSetup

commit 5a52025
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 19:45:49 2024 +0800

    fix: snaps

commit d0ebcd4
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 19:31:53 2024 +0800

    chore: update snap

commit 5e663f7
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 18:59:04 2024 +0800

    fix: should return when posthog is undefined
@sentry-io Sentry.io
Copy link

sentry-io bot commented Feb 8, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: claiming failed e.value(main.a6268689.chunk) View Issue
  • ‼️ Error: verifyHasGas faucet failed <global>(src/lib/analytics/AnalyticsClass) View Issue
  • ‼️ Error: verifyHasGas faucet failed <object>.value(lib/analytics/AnalyticsClass) View Issue
  • ‼️ TypeError: t.postMessage is not a function postMessage(lib/utils/delta) View Issue
  • ‼️ Error: verifyHasGas faucet failed <object>.value(lib/analytics/AnalyticsClass) View Issue

Did you find this useful? React with a 👍 or 👎

sirpy added a commit that referenced this pull request Feb 8, 2024
@sirpy
Squashed commit of the following:
6aa6eaa 
commit 3bc2932
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Feb 8 15:37:11 2024 +0000

    chore: release prod version 2.34.0 [skip build]

commit 30e1f3d
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Feb 8 15:10:39 2024 +0000

    chore: release qa version 2.33.1-1 [skip build]

commit 81f0e94
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Feb 8 23:09:21 2024 +0800

    fix: snapshots

commit 5f3fad8
Merge: 3519e18 3f84cfa
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Feb 8 22:42:43 2024 +0800

    Merge branch 'master' of github.com:GoodDollar/GoodDAPP

commit 3519e18
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Feb 8 22:41:29 2024 +0800

    bump wallet-chat

commit 3f84cfa
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Feb 8 14:29:07 2024 +0000

    chore: release qa version 2.33.1-0 [skip build]

commit 2612971
Author: LewisB <lewis@gooddollar.org>
Date:   Wed Feb 7 15:46:36 2024 +0800

    fix: move tokensymbol to amount

commit 96ca3fc
Merge: bfa12e2 6c88f2b
Author: LewisB <lewis@gooddollar.org>
Date:   Wed Feb 7 01:13:27 2024 +0800

    Merge branch 'master' of github.com:GoodDollar/GoodDAPP

commit 6c88f2b
Author: johnsmith-gooddollar <89783679+johnsmith-gooddollar@users.noreply.github.com>
Date:   Mon Feb 5 11:53:15 2024 +0200

    (Chore) Log network errors once per session/refresh (#4211)

    * revert log.error at wallet class, add global errors filtering

    * add log axios errors once

    * add log http providers once

    * apply changes requested

    * Update src/lib/wallet/MultipleHttpProvider.js

    ---------

    Co-authored-by: sirpy <hadar@gooddollar.org>

commit bfa12e2
Merge: 63267b5 db59b61
Author: LewisB <lewis@gooddollar.org>
Date:   Fri Feb 2 20:20:34 2024 +0800

    Merge branch 'master' of github.com:GoodDollar/GoodDAPP

commit db59b61
Author: LewisB <lewis@gooddollar.org>
Date:   Wed Jan 31 22:05:25 2024 +0800

    fix: typo in next-tasks feature-flag

commit 63267b5
Author: LewisB <lewis@gooddollar.org>
Date:   Wed Jan 31 22:05:25 2024 +0800

    fix: typo in next-tasks feature-flag

commit 224e35c
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 14:30:21 2024 +0200

    add log http providers once

commit b3db632
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 14:21:53 2024 +0200

    add log axios errors once

commit 8af89dd
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 14:09:58 2024 +0200

    revert log.error at wallet class, add global errors filtering

commit 509c78a
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 13:16:10 2024 +0200

    hotfix: logError

commit 94ead3d
Author: John Smith <alexey@gooddollar.org>
Date:   Tue Jan 30 13:07:25 2024 +0200

    make gtag snippet looking exactly as example from docs

commit 5375f31
Author: Lewis B <laurence@gooddollar.org>
Date:   Tue Jan 30 13:52:18 2024 +0800

    fix: replace dataLayer with  gtag in GoogleWrapper (#4209)

    * fix: replace dataLayer with  gtag in GoogleWrapper

    * fix: implement gtag correctly

commit 4e98a61
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 22:11:57 2024 +0800

    add: log, increase poll time for receipt to align with block time

commit 91109b9
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Jan 25 14:05:12 2024 +0000

    chore: release prod version 2.33.0 [skip build]

commit d0d4e64
Author: Techadmin <techadmin@gooddollar.org>
Date:   Thu Jan 25 12:17:10 2024 +0000

    chore: release qa version 2.32.1-1 [skip build]

commit bbfd3ec
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 19:53:52 2024 +0800

    fix: snaps after running blockchainSetup

commit 5a52025
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 19:45:49 2024 +0800

    fix: snaps

commit d0ebcd4
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 19:31:53 2024 +0800

    chore: update snap

commit 5e663f7
Author: LewisB <lewis@gooddollar.org>
Date:   Thu Jan 25 18:59:04 2024 +0800

    fix: should return when posthog is undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirpy sirpy sirpy approved these changes

@L03TJ3 L03TJ3 Awaiting requested review from L03TJ3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AxiosError: syncTxFromExplorer failed: Network Error
2 participants
@johnsmith-gooddollar @sirpy