Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize uniswap-widget #434

Closed
1 of 3 tasks
L03TJ3 opened this issue Jun 22, 2023 · 10 comments
Closed
1 of 3 tasks

Finalize uniswap-widget #434

L03TJ3 opened this issue Jun 22, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jun 22, 2023

Description
we wanted to have an MVP up because liquidity as being moved already
some left-over todo's are:

@L03TJ3 L03TJ3 added the enhancement New feature or request label Jun 22, 2023
@L03TJ3 L03TJ3 self-assigned this Jun 22, 2023
@L03TJ3 L03TJ3 mentioned this issue Jun 26, 2023
12 tasks
@vldkhh
Copy link

vldkhh commented Jul 4, 2023

@L03TJ3 still reproduces on dev
image.png

Also 'null' errors appear
image.png

@sirpy
Copy link
Contributor

sirpy commented Jul 4, 2023

@vldkhh the lockdown-install is not related to us, it must be some extension you have
@L03TJ3 i think we might need to fix the Logo link from the list we use, verify that Celo logo link in the list is working

@L03TJ3
Copy link
Collaborator Author

L03TJ3 commented Jul 10, 2023

@sirpy The link is fine
its just caused by this issue: Uniswap/widgets#602

@sirpy
Copy link
Contributor

sirpy commented Jul 11, 2023

@L03TJ3 the issue you opened on uniswap doesnt describe what causes it only that it happens.
when I look at the console logs you supplied i see a lot of fetching of "pngs" returned with 404 which means it wasnt able to fetch the logos.

@L03TJ3
Copy link
Collaborator Author

L03TJ3 commented Jul 11, 2023

I don't know what causes it... All I know is so far is that when using a custom list:

  1. the DEFAULT native token logo suddenly stops working
  2. adding the native token to the list, have it show up twice but the link still sometimes works/doesnt work

I have not gone over the full list yet to see which png are loading up or not

@L03TJ3
Copy link
Collaborator Author

L03TJ3 commented Mar 22, 2024

@decentralauren when considering re-enabling the swap we should re-test current handling of errors / transactions failed etc.

The logo issue is opened a year ago, 0 response. don't think that will be fixed (by them)
@vldkhh maybe for you to re-test (fuse/celo widgets)

@decentralauren
Copy link
Contributor

@vldkhh can you get with Lewis on what needs to be tested so that we can include this work as part of relaunching Swap next week?

@decentralauren
Copy link
Contributor

Fine to not display currency logo as issue is unresolved on Uniswap's side.

@vldkhh
Copy link

vldkhh commented Apr 2, 2024

verified on dev

@vldkhh
Copy link

vldkhh commented Apr 10, 2024

verified on prod

@vldkhh vldkhh closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants