Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes #8

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Bugfixes #8

merged 1 commit into from
Feb 9, 2022

Conversation

dargueta
Copy link
Contributor

@dargueta dargueta commented Feb 9, 2022

See changelog for all changes

@dargueta dargueta requested a review from kstark February 9, 2022 17:49
kstark
kstark approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@kstark kstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much much better than #7 👏

@kstark kstark mentioned this pull request Feb 9, 2022
Closed
@dargueta
Copy link
Contributor Author

dargueta commented Feb 9, 2022

At some point we should move this to CodeFresh since the CI isn't running at all anymore.

@dargueta dargueta merged commit b84b623 into master Feb 9, 2022
@dargueta dargueta deleted the fix-issue-2 branch February 9, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstark kstark kstark approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dargueta @kstark