This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Added note about NodeJS support for early hints #4076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for developer-chrome-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
voxpelli
reviewed
Nov 3, 2022
| @@ -134,7 +134,7 @@ Here is a quick summary of the level of support for Early Hints among popular OS | |||
| - **Apache:** [supported](https://httpd.apache.org/docs/2.4/howto/http2.html#earlyhints) via mod_http2. | |||
| - **H2O:** [supported](https://github.com/h2o/h2o/pull/1767). | |||
| - **NGINX:** [experimental module](https://github.com/nginx-modules/ngx_http_early_hints). | |||
| - **Node:** not yet supported by core. Available as a [draft plugin for Fastify](https://www.npmjs.com/package/fastify-early-hints). | |||
| - **Node:** not yet supported by 16.x (LTS). Implemented in NodeJS 18.x (https://nodejs.org/docs/latest-v18.x/api/http.html#responsewriteearlyhintshints-callback) | |||
There was a problem hiding this comment.
I would mention the exact version it was introduced in and the exact API:s its supported in:
Suggested change
| - **Node:** not yet supported by 16.x (LTS). Implemented in NodeJS 18.x (https://nodejs.org/docs/latest-v18.x/api/http.html#responsewriteearlyhintshints-callback) | |
| - **Node:** supported since [18.11.0](https://nodejs.org/en/blog/release/v18.11.0/) for [http](https://nodejs.org/api/http.html#responsewriteearlyhintshints-callback) and [http2](https://nodejs.org/api/http2.html#responsewriteearlyhintslinks) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: