Skip to content

Commit

Permalink
misc: change connectionId from string to number (#15983)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark authored May 2, 2024
1 parent a511e58 commit 369979f
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 20,348 deletions.
2 changes: 1 addition & 1 deletion core/lib/lantern/types/lantern.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class NetworkRequest<T = any> {
record?: T;

requestId: string;
connectionId: string;
connectionId: number;
connectionReused: boolean;
url: string;
protocol: string;
Expand Down
4 changes: 2 additions & 2 deletions core/lib/network-request.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const RESOURCE_TYPES = {
class NetworkRequest {
constructor() {
this.requestId = '';
this.connectionId = '0';
this.connectionId = 0;
this.connectionReused = false;

this.url = '';
Expand Down Expand Up @@ -344,7 +344,7 @@ class NetworkRequest {
_onResponse(response, timestamp, resourceType) {
this.url = response.url;

this.connectionId = String(response.connectionId);
this.connectionId = response.connectionId;
this.connectionReused = response.connectionReused;

if (response.protocol) this.protocol = response.protocol;
Expand Down
Loading

0 comments on commit 369979f

Please sign in to comment.