tests(lantern): refactor to DevTools test convention (#16072)

.eslintignore

@@ -19,3 +19,5 @@ third-party/**
 **/*.d.cts
 
 page-functions-test-case*out*.js
+# TODO(15841): remove when importing Lantern from npm
+core/lib/lantern/**/*.test.js

core/test/lib/lantern/base-node-test.js → core/lib/lantern/BaseNode.test.js

@@ -6,7 +6,7 @@
 
 import assert from 'assert/strict';
 
-import * as Lantern from '../../../lib/lantern/lantern.js';
+import * as Lantern from './lantern.js';
 
 const {BaseNode, NetworkNode} = Lantern;
 

core/test/lib/lantern/page-dependency-graph-test.js → core/lib/lantern/PageDependencyGraph.test.js

@@ -6,7 +6,7 @@
 
 import assert from 'assert/strict';
 
-import * as Lantern from '../../../lib/lantern/lantern.js';
+import * as Lantern from './lantern.js';
 
 const {PageDependencyGraph, NetworkRequestTypes} = Lantern;
 

core/test/lib/lantern/tbt-utils-test.js → core/lib/lantern/TBTUtils.test.js

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import * as Lantern from '../../../lib/lantern/lantern.js';
+import * as Lantern from './lantern.js';
 
 const {calculateSumOfBlockingTime} = Lantern.TBTUtils;
 

core/test/lib/lantern/metrics/first-contentful-paint-test.js → core/lib/lantern/metrics/FirstContentfulPaint.test.js

@@ -6,8 +6,8 @@
 
 import assert from 'assert/strict';
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
-import {readJson} from '../../../test-utils.js';
+import * as Lantern from '../lantern.js';
+import {readJson} from '../../../test/test-utils.js';
 import {getComputationDataFromFixture} from './MetricTestUtils.js';
 
 const {FirstContentfulPaint} = Lantern.Metrics;

core/test/lib/lantern/metrics/interactive-test.js → core/lib/lantern/metrics/Interactive.test.js

@@ -6,9 +6,9 @@
 
 import assert from 'assert/strict';
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
+import * as Lantern from '../lantern.js';
 import {getComputationDataFromFixture} from './MetricTestUtils.js';
-import {readJson} from '../../../test-utils.js';
+import {readJson} from '../../../test/test-utils.js';
 
 const {Interactive, FirstContentfulPaint, LargestContentfulPaint} = Lantern.Metrics;
 

core/test/lib/lantern/metrics/lantern-largest-contentful-paint-test.js → core/lib/lantern/metrics/LargestContentfulPaint.test.js

@@ -6,9 +6,9 @@
 
 import assert from 'assert/strict';
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
+import * as Lantern from '../lantern.js';
 import {getComputationDataFromFixture} from './MetricTestUtils.js';
-import {readJson} from '../../../test-utils.js';
+import {readJson} from '../../../test/test-utils.js';
 
 const {FirstContentfulPaint, LargestContentfulPaint} = Lantern.Metrics;
 

core/test/lib/lantern/metrics/MetricTestUtils.js → core/lib/lantern/metrics/MetricTestUtils.js

@@ -6,8 +6,8 @@
 
 import * as TraceEngine from '@paulirish/trace_engine';
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
-import {polyfillDOMRect} from '../../../../lib/polyfill-dom-rect.js';
+import * as Lantern from '../lantern.js';
+import {polyfillDOMRect} from '../../polyfill-dom-rect.js';
 
 polyfillDOMRect();
 

core/test/lib/lantern/metrics/speed-index-test.js → core/lib/lantern/metrics/SpeedIndex.test.js

@@ -4,8 +4,8 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
-import {readJson} from '../../../test-utils.js';
+import * as Lantern from '../lantern.js';
+import {readJson} from '../../../test/test-utils.js';
 import {getComputationDataFromFixture} from './MetricTestUtils.js';
 
 const {SpeedIndex, FirstContentfulPaint} = Lantern.Metrics;

core/test/lib/lantern/simulation/connection-pool-test.js → core/lib/lantern/simulation/ConnectionPool.test.js

@@ -7,7 +7,7 @@
 import assert from 'assert/strict';
 import {URL} from 'url';
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
+import * as Lantern from '../lantern.js';
 
 const {ConnectionPool} = Lantern.Simulation;
 

core/test/lib/lantern/simulation/dns-cache-test.js → core/lib/lantern/simulation/DNSCache.test.js

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
+import * as Lantern from '../lantern.js';
 
 const {DNSCache} = Lantern.Simulation;
 

core/test/lib/lantern/simulation/network-analyzer-test.js → core/lib/lantern/simulation/NetworkAnalyzer.test.js

@@ -6,8 +6,8 @@
 
 import assert from 'assert/strict';
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
-import {readJson} from '../../../test-utils.js';
+import * as Lantern from '../lantern.js';
+import {readJson} from '../../../test/test-utils.js';
 import {runTraceEngine} from '../metrics/MetricTestUtils.js';
 
 const {NetworkAnalyzer} = Lantern.Simulation;

core/test/lib/lantern/simulation/simulator-test.js → core/lib/lantern/simulation/Simulator.test.js

@@ -6,9 +6,9 @@
 
 import assert from 'assert/strict';
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
-import {readJson} from '../../../test-utils.js';
-import {runTraceEngine} from '../metrics/MetricTestUtils.js';
+import * as Lantern from '../lantern.js';
+import {readJson} from '../../../test/test-utils.js';
+import {runTraceEngine} from '../../../test/lib/lantern/metrics/MetricTestUtils.js';
 
 const {NetworkNode, CPUNode} = Lantern;
 const {Simulator, DNSCache} = Lantern.Simulation;

core/test/lib/lantern/simulation/tcp-connection-test.js → core/lib/lantern/simulation/TCPConnection.test.js

@@ -6,7 +6,7 @@
 
 import assert from 'assert/strict';
 
-import * as Lantern from '../../../../lib/lantern/lantern.js';
+import * as Lantern from '../lantern.js';
 
 const {TcpConnection} = Lantern.Simulation;
 

core/scripts/i18n/collect-strings.js

@@ -50,6 +50,7 @@ const ignoredPathComponents = [
   '**/core/lib/stack-packs.js',
   '**/test/**',
   '**/*-test.js',
+  '**/*.test.js',
   '**/*-renderer.js',
   '**/util-commonjs.js',
   'treemap/app/src/main.js',

core/test/scripts/run-mocha-tests.js

@@ -171,6 +171,7 @@ const defaultTestMatches = [
   'cli/**/*-test.js',
   'core/**/*-test.js',
   'core/test/**/*-test-pptr.js',
+  'core/lib/lantern/*.test.js',
   'report/**/*-test.js',
   'shared/**/*-test.js',
   'third-party/**/*-test.js',

tsconfig.json

@@ -66,13 +66,15 @@
     "core/test/lib/emulation-test.js",
     "core/test/lib/i18n/i18n-test.js",
     "core/test/lib/icons-test.js",
-    "core/test/lib/lantern/base-node-test.js",
-    "core/test/lib/lantern/metrics/*",
-    "core/test/lib/lantern/page-dependency-graph-test.js",
-    "core/test/lib/lantern/simulation/connection-pool-test.js",
-    "core/test/lib/lantern/simulation/dns-cache-test.js",
-    "core/test/lib/lantern/simulation/network-analyzer-test.js",
-    "core/test/lib/lantern/simulation/simulator-test.js",
+    // TODO(15841): remove when importing Lantern from npm
+    "core/lib/lantern/BaseNode.test.js",
+    "core/lib/lantern/metrics/*.test.js",
+    "core/lib/lantern/PageDependencyGraph.test.js",
+    "core/lib/lantern/simulation/ConnectionPool.test.js",
+    "core/lib/lantern/simulation/DNSCache.test.js",
+    "core/lib/lantern/simulation/NetworkAnalyzer.test.js",
+    "core/lib/lantern/simulation/Simulator.test.js",
+    // ------ done TODO
     "core/test/lib/lh-element-test.js",
     "core/test/lib/lighthouse-compatibility-test.js",
     "core/test/lib/manifest-parser-test.js",
@@ -109,6 +111,6 @@
     "core/test/computed/metrics/interactive-test.js",
     "core/test/computed/tbt-impact-tasks-test.js",
     "core/test/fixtures/config-plugins/lighthouse-plugin-simple/plugin-simple.js",
-    "core/test/lib/lantern/metrics/MetricTestUtils.js",
+    "core/lib/lantern/metrics/MetricTestUtils.js",
   ],
 }