Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceWorker origin matching doesn't consider ports #532

Closed
paulirish opened this issue Jul 27, 2016 · 0 comments
Closed

ServiceWorker origin matching doesn't consider ports #532

paulirish opened this issue Jul 27, 2016 · 0 comments

Comments

@paulirish
Copy link
Member

Which means a SW for localhost:8080 is gonna get "matched" for a site on localhost:3000.

Yikes

Should be an easy fix, obv.
@paulirish paulirish mentioned this issue Jul 27, 2016
Merged
paullewis added a commit that referenced this issue Jul 27, 2016
@paullewis
Handles ports for SW.
1f08aa0 
SW check needs ports.

Fixes #532
@paullewis paullewis mentioned this issue Jul 27, 2016
Merged
paulirish pushed a commit that referenced this issue Jul 27, 2016
@paullewis @paulirish
Handles ports for SW. (#535)
8c39f91 
* Handles ports for SW.

Fixes #532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulirish