core(js-bundles): return error object when sizes cannot be determined #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Mar 10, 2020
There was a problem hiding this comment.
@connorjclark do you still want this change? It reads reasonably to me all these months later, so I'm going to assume yes :)
edit: oh, yeah, you updated the branch, so definitely yes :)
| return failureResult; | ||
| const error = `${map.url()} mapping for line out of bounds: ${lineNum + 1}`; | ||
| log.error('JSBundles', error); | ||
| return {error}; |
There was a problem hiding this comment.
good point, codecov, should have a test for this case :)
There was a problem hiding this comment.
missing coverage is for the "line out of bounds" case
There was a problem hiding this comment.
ah, I meant to get that w/ d517ec5 , but I tested the wrong thing (column OOB instead of line OOB)
| return failureResult; | ||
| const error = `${map.url()} mapping for line out of bounds: ${lineNum + 1}`; | ||
| log.error('JSBundles', error); | ||
| return {error}; |
There was a problem hiding this comment.
missing coverage is for the "line out of bounds" case
Co-authored-by: Brendan Kenny <bckenny@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change forces consumers of JSBundles to explicitly check for errors before using
.sizes, instead of relying on a no-op behavior by returning an empty result.We could emit a warning when an audit encounters this, but I'm not certain we should. The
valid-sourcemapsaudit will certainly make this error visible. If other audits emit a warning I would want a way to link to thevalid-sourcemapsaudit from the warning.