-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.4.1 #11513
v6.4.1 #11513
Conversation
changelog.md
Outdated
# 6.4.1 (2020-10-02) | ||
[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v6.4.0...v6.4.1) | ||
|
||
This is a minor release to fix an issue in the npm package where v6.4.0 was published as ~15GB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~15GB
68.5MB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I misread the severity of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sorry if I misled you @connorjclark I was trying to say this probably wasn't a showstopper since npm installing all of our deps is apparently 15GB so us increasing ~50MB isn't the end of the world, but this fix combined with the many malformed request issue in #11503 would be a nice 6.4.1 anyway if you want to continue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea might as well keep going, but I probably won't follow up with a CDT release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was my fault, I read it quickly this morning then went off to do a bunch of errands, so all day this was in my head and as soon as I got to a computer I didn't check any of my assumptions
|
||
## Misc | ||
|
||
* add chromium webtests to npmignore ([#11512](https://github.com/GoogleChrome/lighthouse/pull/11512)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really the important part for this release was the .tmp
part of this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well the only things inside .tmp
were chromium web test stuff. this message seems to get at the heart of it already, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fair :)
No description provided.