-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: add save latest run script #11516
Conversation
cd $LH_ROOT/latest-run | ||
|
||
mkdir -p $TARGET_DIR | ||
cp artifacts.json $TARGET_DIR/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing lhr..want to just copy every file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing lhr.
that was somewhat intentional but I suppose it wouldn't hurt :)
want to just copy every file?
not really since I keep lots of other stuff in there 😆 , but now that you mention it I think we need to for runtimeError artifacts anyway. I'll move my stuff and copy all files 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cd "$LH_ROOT/latest-run" | ||
mkdir -p "$TARGET_DIR" | ||
|
||
for file in *.json ; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for file in *.json ; do | |
for file in *.* ; do |
i mean we dont have non-json now but figure it can be flexible for all non-directories..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't that pickup the default of .bak
?
selfishly that also means it starts to pick up all the various *.zip
s when I need to upload these to issues 😬
can we only do this when we have a need for something other than json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't that pickup the default of .bak?
lol right.. suggestion above for that.
can we only do this when we have a need for something other than json?
sure
cd "$LH_ROOT/latest-run" | ||
mkdir -p "$TARGET_DIR" | ||
|
||
for file in *.json ; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't that pickup the default of .bak?
lol right.. suggestion above for that.
can we only do this when we have a need for something other than json?
sure
Co-authored-by: Paul Irish <paulirish@google.com>
Summary
Adds a script for stashing the default latest run artifacts in a subdirectory. I do this on a regular basis when investigating tracing issues and figured it'd be helpful for others too.
Example Usage
Related Issues/PRs
#10869 (comment) made me think of it