Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: add @types/yargs-parser #11517

Merged
merged 1 commit into from
Oct 5, 2020
Merged

deps: add @types/yargs-parser #11517

merged 1 commit into from
Oct 5, 2020

Conversation

connorjclark
Copy link
Collaborator

resolves issue found in another PR: #11271 (comment)

@connorjclark connorjclark requested a review from a team as a code owner October 5, 2020 19:22
@connorjclark connorjclark requested review from patrickhulce and removed request for a team October 5, 2020 19:22
patrickhulce
patrickhulce approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like they flipped to typescript at v19.x.x we could benefit from on update :)

LGTM for problem at hand though 👍

@patrickhulce patrickhulce merged commit 069364e into master Oct 5, 2020
@patrickhulce patrickhulce deleted the deps-yargs-parser-types branch October 5, 2020 20:05
@brendankenny
Copy link
Member

The latest types have probably drifted quite a bit from our yargs@3.32.0, but looks like they'll probably be closer than those three year old types it looks like someone threw together in about 30 seconds :)

@patrickhulce
Copy link
Collaborator

patrickhulce commented Oct 5, 2020 •
edited
Loading

The latest types have probably drifted quite a bit from our yargs@3.32.0

These are for yargs*-parser* though which is at 18.1.3, no?

@brendankenny
Copy link
Member

These are for yargs*-parser* though which is at 18.1.3, no?

Oh, right. Well the three year old types were still useless, but yeah, we probably should have just updated since we already broke the seal in #10723. Oh well :)

@connorjclark connorjclark restored the deps-yargs-parser-types branch January 25, 2022 23:29
@connorjclark connorjclark deleted the deps-yargs-parser-types branch January 26, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees

@patrickhulce patrickhulce

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorjclark @brendankenny @patrickhulce @googlebot @devtools-bot