Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: limit LCP element audit to m87 and earlier #11625

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
LCP in Canary has flipped to including removed elements by default.

https://chromium-review.googlesource.com/c/chromium/src/+/2480845

Long-term we should find a way to surface this element and/or potentially keep 6.x on the old LCP version, but for now we'll make PRs landable again.

@patrickhulce patrickhulce requested a review from a team as a code owner November 3, 2020 20:47
@patrickhulce patrickhulce requested review from Beytoven and removed request for a team November 3, 2020 20:47
@google-cla google-cla bot added the cla: yes label Nov 3, 2020
@Beytoven Beytoven merged commit 0a2d931 into master Nov 4, 2020
@Beytoven Beytoven deleted the fix_lcp_smoke branch November 4, 2020 15:58
@brendankenny
Copy link
Member

brendankenny commented Nov 4, 2020

Long-term we should find a way to surface this element and/or potentially keep 6.x on the old LCP version

@patrickhulce do you mind filing a bug on this and maybe also mention removing this _maxChromiumMilestone entry in the issue?

One benefit of _minChromiumMilestone is that it eventually ages in and always runs since chrome versions only increase :) While _maxChromiumMilestone could easily slip by and appear to be functioning as a test when it isn't being checked against anything anymore, so we have to be slightly more vigilant (though ideally there'll be a new smoke test for the new behavior, so it won't really matter if there's also an old test hanging around not doing anything).

@patrickhulce
Copy link
Collaborator Author

done 👍

@brendankenny
Copy link
Member

haha, I meant just this particular _maxChromiumMilestone entry, not support altogether :) Maybe we could come up with some expiration mechanism for it or something, but it does seem like there's not a good way to do this without a max companion to the min.

@connorjclark
Copy link
Collaborator

connorjclark commented Nov 5, 2020

_failAt: new Date('2021-01-01') seems cool to me. ticking time bomb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants