Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update throttling reference #11645

Merged
merged 2 commits into from
Nov 12, 2020
Merged

docs: update throttling reference #11645

merged 2 commits into from
Nov 12, 2020

Conversation

danieleloscozzese
Copy link
Contributor

Summary

This is a documentation update. The current link on the throttling page links to a now-outdated version of the constants file, and I have updated that link to point to the current version (via master in the URL, please let me know if I should change that). I also split the links so one points to the values in use and one to the setting of the default.

I made this change because I am documenting some use of Lighthouse for @Subito-it and I wanted to add a reference to the default value, and the file has been changed since the original link was written.

Update link to default values.
Split link to values from setting of default.
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing and helping out @DanArthurGallagher! 🎉

docs/throttling.md Outdated Show resolved Hide resolved
Preserve the link's integrity even if the file is rearranged in the future.
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DanArthurGallagher! 🎉

@patrickhulce patrickhulce merged commit 25b86af into GoogleChrome:master Nov 12, 2020
@danieleloscozzese danieleloscozzese deleted the update-throttling-docs branch November 12, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants