tests: update github actions to use env files #11674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # TODO: switch back to arduino/setup-protoc after the pagination fix lands: | ||
| # https://github.com/arduino/setup-protoc/pull/9 | ||
| uses: solo-io/setup-protoc@1f5d8b5 | ||
| uses: arduino/setup-protoc@64c0c85 |
There was a problem hiding this comment.
I think specifying a version number is just as safe, no? And much more clear what the capabilities are (just go straight to the releases page)
There was a problem hiding this comment.
I think specifying a version number is just as safe, no?
they're just git tags, so they can be moved and changed at any time, unfortunately.
connorjclark
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
I don't see any other dependency actions that need to be updated due to the looser
v*pinning on them, but I guess we'll see.