Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(driver): resume on debugger statements #11727

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
Skip pauses doesn't actually skip pauses these days (maybe always?)... 😮

see #11725 for more context

Related Issues/PRs
fixes #11725

@patrickhulce patrickhulce requested a review from a team as a code owner November 30, 2020 21:52
@patrickhulce patrickhulce requested review from connorjclark and removed request for a team November 30, 2020 21:52
@google-cla google-cla bot added the cla: yes label Nov 30, 2020
Co-authored-by: Connor Clark <cjamcl@google.com>
@connorjclark connorjclark merged commit 361dbe7 into master Nov 30, 2020
@connorjclark connorjclark deleted the resume_debugger branch November 30, 2020 22:47
@Sarthakagarwal22
Copy link

I feel this is still not done completely. I have a website https://healthhub.jio.com/vaccination/ . I am unable to generate the lighthouse report for it. Using chrome 91 on MacOS. Tried with and without clear storage and simulated throttling, mobile, desktop without PWA, but nothing works. Any help would be highly appreciated.

@patrickhulce
Copy link
Collaborator Author

@Sarthakagarwal22 that page enters an infinite loop of debugger statements such that no analysis can be performed. There's nothing Lighthouse can do about that and the message you receive in the report "Lighthouse was unable to reliably load the URL you requested because the page stopped responding." is accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse always hangs on debugger statements
4 participants