Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smoke): add category to run some perf tests in parallel #11932

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

adamraine
Copy link
Member

Closes #11522

Was goin back and forth on naming this perf-parallel or perf-diagnostics. Settled on the latter for now, open to other suggestions.

Animation and third party facades smoke tests are moved into perf-diagnostics.

@adamraine adamraine requested a review from a team as a code owner January 8, 2021 20:44
@adamraine adamraine requested review from Beytoven and removed request for a team January 8, 2021 20:44
@google-cla google-cla bot added the cla: yes label Jan 8, 2021
@patrickhulce
Copy link
Collaborator

whatever happened to @paulirish 's push for URL-based smokes instead of these groups? is that a phantom PR somewhere, issue, never got out of a comment? this is a good reminder to try that out :)

this is a good move either way though since these diagnostics aren't resource sensitive to begin with 👍

@paulirish
Copy link
Member

whatever happened to @paulirish 's push for URL-based smokes instead of these groups? is that a phantom PR somewhere, issue, never got out of a comment? this is a good reminder to try that out :)

yeahhhhhhhh buddy.

the idea is chillin in a PR comment #9676 (comment)

@adamraine adamraine merged commit 1a7b852 into master Jan 15, 2021
@adamraine adamraine deleted the perf-parallel branch January 15, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some perf smoke test do not need to be run serially
5 participants