core(fr): filter configs by gather mode #11941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Jan 12, 2021
| 'use strict'; | ||
|
|
||
| /** | ||
| * |
There was a problem hiding this comment.
Could you add a jsdoc description to these functions. It isn't obvious how each list is being filtered by the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This completes the core snapshot mode support for Fraggle Rock (further gatherer support pending) by filtering out any audits from a config that don't support the gatherer mode being run. This eliminates the huge mess of errors you'd see in the report when previously running in snapshot mode.
I decided against a property in
settingsbecause our intention is to always have the entrypoint be different for every entry mode (so there is no benefit to duplicate specification in the config) and the same config is shared between many modes which created potential for confusion if thegatherModevalue was set to a value that didn't match audits/gatherers defined in the config. Contrast this withonlyAudits/onlyCategorieswhich has no impact on the entrypoint.Related Issues/PRs
ref #11313