core(fr): add navigation runner #11975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
commented
Jan 19, 2021
| /** | ||
| * @param {{driver: Driver, config: LH.Config.FRConfig, requestedUrl: string}} args | ||
| */ | ||
| async function _setup({driver, config, requestedUrl}) { |
There was a problem hiding this comment.
this file is where all the interesting review bits are, the rest is test machinery
adamraine
reviewed
Jan 20, 2021
lighthouse-core/test/fraggle-rock/gather/navigation-runner-test.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the basic framework of the navigation runner, the equivalent of
GatherRunnerin Fraggle Rock land. Its structure should be very familiar to anyone who's touchedGatherRunnerbefore.It was pretty difficult to come up with a breaking point for a smaller PR, so you'll see plenty of
TODOs,it.todos and some private variable access, but the full list of what's coming is in #11313. I don't think there's going to be anything super controversial here since it's mostly matching the previous structure.The one sticking point that come up that will require a bit more ironing out is how
supportedModes: ['navigation']will be handled since the place we left off in the design doc doesn't feel right now that I've prototyped out a few more gatherers. I think we'll need a third, matching set of methods when something only supportsnavigation. i.e.beforeNavigation,afterNavigation, but we can cross that bridge when we hit that gatherer (TagsBlockingFirstPaintwas the specific gatherer I had in mind, which installs a page-side listener but then basically needssnapshotlater).Related Issues/PRs
ref #11313
design doc