core(tap-targets): drop custom node rect creation #12005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jan 26, 2021
| @@ -4827,12 +4827,12 @@ | |||
| "path": "3,HTML,1,BODY,17,BUTTON", | |||
| "selector": "body > button.small-button", | |||
| "boundingRect": { | |||
| "top": 484, | |||
There was a problem hiding this comment.
just noticed these (huge) differences :o need to investigate
There was a problem hiding this comment.
ok I had to remind myself that this bounding rect is only used for full page screenshot positioning, and the value will have no effect on tap target results
I reckon numbers are so different because we changed deviceScaleFactor
Running LH against dbw_tester and viewing report shows that the screenshot lines up just fine.
I updated the sample artifact for TapTargets, it was a little old.
brendankenny
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11948