cli: do not set AutofillShowTypePredictions

[connorjclark]

fixes #11985

[brendankenny]

should all traces of it be removed?

like

lighthouse/lighthouse-cli/test/smokehouse/lighthouse-runners/bundle.js

Lines 44 to 46 in 5c32e64

	const launchedChrome = await ChromeLauncher.launch({
	chromeFlags: ['--enable-features=AutofillShowTypePredictions'],
	});

and

lighthouse/lighthouse-cli/test/smokehouse/test-definitions/a11y/expectations.js

Line 531 in 5c32e64

// TODO(paulirish): restore when we stop using --enable-features=AutofillShowTypePredictions

and

lighthouse/lighthouse-core/lib/page-functions.js

Lines 141 to 143 in 5c32e64

	// Autofill information that is injected into the snippet via AutofillShowTypePredictions
	// TODO(paulirish): Don't clean title attribute from all elements if it's unnecessary
	const autoFillIgnoreAttrs = ['autofill-information', 'autofill-prediction', 'title'];

and anything in those PRs that doesn't just match a AutofillShowTypePredictions search?

[connorjclark]

should all traces of it be removed?

No, I don't think so.

like

lighthouse/lighthouse-cli/test/smokehouse/lighthouse-runners/bundle.js

Lines 44 to 46 in 5c32e64

	const launchedChrome = await ChromeLauncher.launch({
	chromeFlags: ['--enable-features=AutofillShowTypePredictions'],
	});

There's still a smoke test for this experimental audit.

lighthouse/lighthouse-cli/test/smokehouse/test-definitions/a11y/expectations.js

Line 531 in 5c32e64

// TODO(paulirish): restore when we stop using --enable-features=AutofillShowTypePredictions

same

lighthouse/lighthouse-core/lib/page-functions.js

Lines 141 to 143 in 5c32e64

	// Autofill information that is injected into the snippet via AutofillShowTypePredictions
	// TODO(paulirish): Don't clean title attribute from all elements if it's unnecessary
	const autoFillIgnoreAttrs = ['autofill-information', 'autofill-prediction', 'title'];

and anything in those PRs that doesn't just match a AutofillShowTypePredictions search?

still supporting experimental usage, should anyone care..

We could remove more but this is the minimal to have any impact. Anything else might be churn (removed but brought back later).

[connorjclark]

Ahhhh I assumed the chrome flags being set in the smoke test runner would apply to all, but that is just bundle.js. The normal run of smoke tests uses the regular chrome launching...

Add the flag to cli.js, or just remove/comment out form smoke tests?

EDIT: I commented out the smoke tests.

[brendankenny]

still supporting experimental usage, should anyone care..

FWIW historically we've been in this exact position with an unsupported feature hidden by a flag that no one owns like two or three times now and it always ends up the same way.