Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix js edge case in minification estimator #12067

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

EYHN
Copy link
Contributor

@EYHN EYHN commented Feb 9, 2021

Summary
Added handling of a edge case in js for minification estimator.

Related Issues/PRs

fixed #12060

@EYHN EYHN requested a review from a team as a code owner February 9, 2021 03:30
@EYHN EYHN requested review from adamraine and removed request for a team February 9, 2021 03:30
@google-cla
Copy link

google-cla bot commented Feb 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@EYHN
Copy link
Contributor Author

EYHN commented Feb 9, 2021

@googlebot I signed it!

Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@adamraine adamraine merged commit aaf1365 into GoogleChrome:master Feb 9, 2021
@brendankenny
Copy link
Member

Thanks @EYHN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minification-estimator reports incorrect results
4 participants