Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(cls): refactor CLS and CLS-AF #12069

Merged
merged 3 commits into from
Feb 10, 2021
Merged

core(cls): refactor CLS and CLS-AF #12069

merged 3 commits into from
Feb 10, 2021

Conversation

adamraine
Copy link
Member

Follow up to #12046 (comment) and #12034.

Removes duplicated code which handles the had_recent_input flag in layout shift events.

Plan is to merge after #12046 lands.

@adamraine adamraine requested a review from a team as a code owner February 9, 2021 21:16
@adamraine adamraine requested review from patrickhulce and removed request for a team February 9, 2021 21:16
@google-cla google-cla bot added the cla: yes label Feb 9, 2021
Base automatically changed from lsvariants to master February 9, 2021 21:18
@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no and removed cla: yes labels Feb 9, 2021
patrickhulce
patrickhulce reviewed Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup!

lighthouse-core/computed/layout-shift-variants.js Outdated Show resolved Hide resolved
lighthouse-core/computed/metrics/cumulative-layout-shift.js Show resolved Hide resolved
lighthouse-core/computed/metrics/cumulative-layout-shift-all-frames.js Outdated Show resolved Hide resolved
lighthouse-core/test/computed/metrics/cumulative-layout-shift-all-frames-test.js Outdated Show resolved Hide resolved
@google-cla

This comment has been minimized.

Sign in to view
@connorjclark connorjclark changed the title core(cls): refractor CLS and CLS-AF to use same logic for recent input core(cls): refactor CLS and CLS-AF to use same logic for recent input Feb 10, 2021
patrickhulce
patrickhulce approved these changes Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the error removal 👍

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 10, 2021
@adamraine adamraine changed the title core(cls): refactor CLS and CLS-AF to use same logic for recent input core(cls): refactor CLS and CLS-AF Feb 10, 2021
@adamraine adamraine merged commit c6e14d7 into master Feb 10, 2021
@adamraine adamraine deleted the cls-af-had-recent-input branch February 10, 2021 19:37
paulirish pushed a commit that referenced this pull request Mar 23, 2021
@adamraine @paulirish
core(cls): refactor CLS and CLS-AF (#12069)
ddb9a00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees

@patrickhulce patrickhulce

Labels
cla: yes waiting4committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamraine @patrickhulce @devtools-bot