misc(git3po): merge when green for unstable state too #12078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Feb 10, 2021
|
I feel like I've definitely seen it merge when green but non-required checks were red (like when travis was on until recently), but maybe something changed? |
that's my guess. gh officially says this field is undocumented and indicates they can change behavior whenever. so perhaps they did. |
paulirish
pushed a commit
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unstable means all required checks passed, but some un required checks failed. For us, that means code cov (not required) can prevent our
land-when-greenlabel from working.Only thing documenting
unstableI could find: octokit/octokit.net#1763