Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(ci): update GH actions commit SHAs #12099

Merged
merged 1 commit into from
Feb 17, 2021
Merged

misc(ci): update GH actions commit SHAs #12099

merged 1 commit into from
Feb 17, 2021

Conversation

patrickhulce
Copy link
Collaborator

seems like github actions stopped supporting the short shas 😞 https://github.com/GoogleChrome/lighthouse/runs/1920862528#step:1:26

image

@patrickhulce patrickhulce requested a review from a team as a code owner February 17, 2021 21:47
@patrickhulce patrickhulce requested review from connorjclark and removed request for a team February 17, 2021 21:47
@google-cla google-cla bot added the cla: yes label Feb 17, 2021
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.blog/changelog/2021-01-21-github-actions-short-sha-deprecation/

hmm... ok cool. would have been nice if they sent us direct alerts instead, since they can tell we used short shas. or maybe we missed the deprecation warnings. w.e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants