core(fr): filter out manual-only categories #12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Apr 15, 2021
| @@ -48,16 +50,32 @@ function filterCategoriesByAvailableAudits(categories, availableAudits) { | |||
| if (!categories) return categories; | |||
|
|
|||
| const availableAuditIds = new Set(availableAudits.map(audit => audit.implementation.meta.id)); | |||
| const manualAuditIds = new Set( | |||
There was a problem hiding this comment.
nit: Would a single auditIdToAuditMeta map also work? I don't think you need to change anything unless you see us adding another filter in the future.
There was a problem hiding this comment.
sure I'll refactor 👍
Comment on lines
+120
to
+123
| expect(filtered).not.toMatchObject({ | ||
| timespan: {}, | ||
| navigation: {}, | ||
| }); |
patrickhulce
commented
Apr 19, 2021
| if (!meta) return false; | ||
| return meta.scoreDisplayMode === Audit.SCORING_MODES.MANUAL; | ||
| }); | ||
|
|
There was a problem hiding this comment.
that line is empty of course it's covered...
go home codecov you're drunk 😆
(I'm assuming this is some source mapping issue because line 66 can't be covered, it's a make TS happy check that's impossible, EDIT: I take it back the line is obviously covered it's just the branch that can't. dunno what's going on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the filtering of categories in Fraggle Rock to remove categories that consist only manual audits. This eliminates the UX oddity that you'd run timespan mode and get a
?score for accessibility category because all its real audits were snapshot audits.Related Issues/PRs
ref #11313