core(responsive-images): ignore images larger than viewport #12414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Apr 28, 2021
patrickhulce
force-pushed
the
ignore_too_large_images_responsive
branch
from
8a22712
to
79fadc0
Compare
patrickhulce
commented
Apr 28, 2021
| @@ -415,7 +415,7 @@ const expectations = [ | |||
| screenshot: { | |||
| width: 360, | |||
| // Allow for differences in platforms. | |||
| height: '3755±5', | |||
| height: '1350±20', | |||
There was a problem hiding this comment.
the height of this page is now determined by text (which varies far more between OS) instead of a static height of a declared image, this distinction didn't seem so important as to add fixed heights to every text dom element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor change to the responsive images audit (see #11838).
Related Issues/PRs
fixes #11838